mirrors/arti.git/crates/arti-rpcserver/src/connection.rs, branch arti-v1.2.5 mirror of https://gitlab.torproject.org/tpo/core/arti http://git.dilluti0n.com/mirrors/arti.git/atom?h=arti-v1.2.5 2024-06-10T14:33:01Z Implement rpc::Context on Connection directly 2024-06-10T14:33:01Z Nick Mathewson nickm@torproject.org 2024-06-05T14:00:25Z urn:sha1:aaf12c8970e35ff0f9873cf4c2e27adb2ccaf9e5 This lets us get rid of a now-spurious `RequestContext` wrapper type and an extra layer of indirection; it will also make it easier to treat a Connection _as_ a context, so that we can have a context in the socks-rpc interface code. This patch removes a TODO about "treading carefully" when we make this change. When I added that TODO, I had misremembered some implementation details of the RPC object system. rpc: allow Connection::lookup_object to take &self 2024-06-10T14:33:01Z Nick Mathewson nickm@torproject.org 2024-06-05T13:57:40Z urn:sha1:3f7b69dd772c33175f41675e03b304da5c6ec508 This will allow us to implement rpc::Context on Connection directly. rpc: Make the connection type always-Arc. 2024-06-10T14:33:01Z Nick Mathewson nickm@torproject.org 2024-06-05T13:51:04Z urn:sha1:c4c8f533ac057e405b597d1584711fa95cdae604 Use refactored invoke_rpc_method in rpcserver. 2024-06-10T14:33:01Z Nick Mathewson nickm@torproject.org 2024-06-04T16:42:35Z urn:sha1:5f2aaf5fb15e74d7b75ed9a4aa442e2dcb8ef451 rpc: Pass around our rpc::Context in an Arc. 2024-06-10T14:33:01Z Nick Mathewson nickm@torproject.org 2024-06-04T15:31:19Z urn:sha1:acdc2cbe0bc54141e33da320a9551fbcf2e1d7fc Formerly we used a Box. That was okay at first, but now that we want RPC methods to be able to invoke other RPC methods, we don't want the Invocable methods to have to consume the Context. This requires that Context become Sync. RPC: Expose dispatch table from Context 2024-05-16T12:40:06Z Nick Mathewson nickm@torproject.org 2024-05-14T18:52:36Z urn:sha1:533b34a55b268ec73ac032dd8e3d360f2d43b985 We need to do this so that we can actually invoke RPC functions from one another. rpc: Move typetag onto subtrait of DynMethod 2024-05-16T12:40:04Z Nick Mathewson nickm@torproject.org 2024-05-14T15:21:02Z urn:sha1:0e8608ba76f61a401040c8f762b99e5f3965d8e8 This will allow us to create dispatchable methods that are only invoked from inside the arti code, and are not themselves serializable. rpcserver: rename streams.rs to codecs.rs. 2024-05-09T20:34:17Z Nick Mathewson nickm@torproject.org 2024-05-07T19:07:25Z urn:sha1:86b04a3f12eb145b012541ad69af966966f0b3c8 I think I'm going to add another stream management module here. Refactor: remove existence of HasConstTypeId_ as a trait 2024-04-08T13:00:29Z Nick Mathewson nickm@torproject.org 2024-04-08T12:51:56Z urn:sha1:5155e9add7b0f94a8d95eae257c9c2a3e64d5566 We don't actually need this to be a trait; we just need methods and objects to have a `CONST_TYPE_ID_` if they want to participate in the inventory-based method registry. Removing this trait makes it much simpler to declare methods and objects. Port many of the macros in tor-rpcbase to use derive-deftly. 2024-04-04T20:42:57Z Nick Mathewson nickm@torproject.org 2024-04-04T20:04:39Z urn:sha1:66cfabc442bfc1779a4748b89d0be2d51f908fc9 This simplifies our implementation logic in a few places, and simplifies our invocation syntax greatly. There are a few infelicities, noted in `TODO RPC` comments.