mirrors/arti.git/crates/arti-rpcserver/src/cancel.rs, branch arti-v2.5.0 mirror of https://gitlab.torproject.org/tpo/core/arti http://git.dilluti0n.com/mirrors/arti.git/atom?h=arti-v2.5.0 2026-06-09T15:36:01Z maint: Run maint/add_warning to deny string slices 2026-06-09T15:36:01Z Clara Engler cve@cve.cx 2026-06-09T15:36:01Z urn:sha1:9f5752a77fb57052c06ead0eeae606831f1e8e97 This commit executes maint/add_warning with the just added change to deny string slices except in tests. I recommend auditing this by checking out the previous commit followed by running the script yourself and then verifying that the diff is identical to this commit. This commit makes cargo clippy fail. We will add exceptions in the next commit. Fix name of clippy lint to unchecked_time_subtraction (2) 2025-11-06T11:28:22Z Ian Jackson ijackson@chiark.greenend.org.uk 2025-11-06T11:23:25Z urn:sha1:a5fd5c48ea059a80cc1f6c50e248654b5ff3aaff Run maint/add_warning Switch Cargo.toml files to edition 2024. 2025-08-07T15:28:36Z Nick Mathewson nickm@torproject.org 2025-08-06T01:19:58Z urn:sha1:77b0de43b8c67cdb81befe0680a3df43b6ad37bc First, run ``` git grep -l "^edition =" | xargs perl -i -pe 's/^edition *=.*/edition = "2024"/;' ``` Second, manually verify that all Cargo.toml files have changed, and nothing else has changed. Third, run cargo fmt again. squash! Upgrade rand dependency to 0.9. 2025-03-18T16:09:44Z Nick Mathewson nickm@torproject.org 2025-03-18T13:01:31Z urn:sha1:2f8993c22c2b86010e4fd8b5169ef0ab83f8c754 - `rand::thread_rng()` has been deprecated and renamed to `rand::rng()` tor-rtmock: allow-Decorate every use of MockSleepProvider 2025-03-06T17:18:52Z Ian Jackson ijackson@chiark.greenend.org.uk 2025-03-06T16:57:21Z urn:sha1:a4054ed0d51e7c55946bde3c247190c9bbeef6fb MockSleepProvider and MockSleepRuntime have been declared deprecated by the docs for some time. We're about to mark them `#[deprecated]`. This commit has been split out for clarity of review. cancel: Document deadlock/panic issue and how to avoid it. 2025-01-23T00:39:58Z Nick Mathewson nickm@torproject.org 2025-01-22T16:06:15Z urn:sha1:7a87b684575bc7da4a899f66dcb0ec3bea140fff cancel: Add a TODO about moving the Future inside the lock. 2025-01-23T00:39:58Z Nick Mathewson nickm@torproject.org 2025-01-21T15:35:04Z urn:sha1:d8d47f4d82b1ee1927a8d403d4186acefa09d0e5 Cancel: Drop lock before calling waker. 2025-01-23T00:39:58Z Nick Mathewson nickm@torproject.org 2025-01-21T14:51:50Z urn:sha1:ffca1afad93252673bccdd75e7df7c7851a97efa cancel: Remove FusedFuture implementation. 2025-01-23T00:39:58Z Nick Mathewson nickm@torproject.org 2025-01-21T14:46:56Z urn:sha1:552250eb53bbaaeac7a7300bc6db1981a1d8dfae Nothing used it, and it has some semantic complexity. (see https://gitlab.torproject.org/tpo/core/arti/-/merge_requests/2722#note_3149591 ) cancel: Use Waker::clone_from to avoid needless clones. 2025-01-23T00:39:58Z Nick Mathewson nickm@torproject.org 2025-01-21T14:41:22Z urn:sha1:51a3503f6dcbfa397827505a6801a72df17fa250 The Waker::clone_from implementation uses Waker::will_wake to avoid unnecessarily cloning a Waker that it already has a copy of.