mirrors/arti.git/crates/arti-rpcserver/src/cancel.rs, branch arti-v1.4.0

cancel: Document deadlock/panic issue and how to avoid it.

2025-01-23T00:39:58Z

cancel: Add a TODO about moving the Future inside the lock.

2025-01-23T00:39:58Z

Cancel: Drop lock before calling waker.

2025-01-23T00:39:58Z

cancel: Remove FusedFuture implementation.

2025-01-23T00:39:58Z

Nothing used it, and it has some semantic complexity. (see https://gitlab.torproject.org/tpo/core/arti/-/merge_requests/2722#note_3149591 )

cancel: Use Waker::clone_from to avoid needless clones.

2025-01-23T00:39:58Z

The Waker::clone_from implementation uses Waker::will_wake to avoid unnecessarily cloning a Waker that it already has a copy of.

rpc: Strengthen guarantees from Cancel.

2025-01-16T20:04:54Z

Cancellation is now fallable, which allows us to detect attempts to cancel which cannot work. We now guarantee that when you try to cancel a `Cancel` future, either the cancel operation will succeed, or the future will return (or will have already returned) Ok(), but not both, and not neither. Closes #818.

extract tor_async_utils::oneshot into ::oneshot-fused-workaround

2024-08-28T14:27:46Z

Having this in the `tor-async-utils` crate prevents us from doing both of the following without introducing a circular dependency: * using it in `tor-rtmock` (which we currently do, particularly in tests). * using `tor-rtmock` to test things in `tor-async-utils`. We don't do this yet, but it is generally sensible to do so. In particular we want to move the `stream_peak` module there, which is currently tested with `tor-rtmock`. Moving this into its own crate avoids this circular dependency.

Run maint/add_warning.

2024-03-13T16:30:53Z

oneshot: Use veneer in arti-rpcserver

2023-10-11T15:19:46Z

Run maint/add_warning to add lint block everywhere

2023-08-23T09:34:00Z