mirrors/arti.git/crates/arti-rpc-client-core/src, branch arti-v1.4.0mirror of https://gitlab.torproject.org/tpo/core/arti
http://git.dilluti0n.com/mirrors/arti.git/atom?h=arti-v1.4.02025-02-04T19:41:15Zrpclib: Improve output for ConnectFailure2025-02-04T19:41:15ZNick Mathewsonnickm@torproject.org2025-02-04T17:28:02Zurn:sha1:dffe9330ab57d90f844f2aac950e4cbc2fc7a70b
We want to explain better what has happened, not only with the final
fatal error, but with any nonfatal errors that occurred in the middle.
Closes #1826.
rpclib: Include sources when formatting FFI errors.2025-02-04T19:41:15ZNick Mathewsonnickm@torproject.org2025-02-04T15:40:03Zurn:sha1:921ae4c6cea7893aae854e562720310388b8897b
Closes #1650.
rpclib: Obey error Display convention wrt sources.2025-02-04T19:41:15ZNick Mathewsonnickm@torproject.org2025-02-04T15:20:43Zurn:sha1:c8f614faf5084c300a71b6e607a0b189df8830da
In general, we try to obey the convention that an error's Display
method does not display that error's sources.
Part of #1650.
rpclib: Move socketpair to a testing module; use it in llconn tests2025-02-03T18:41:15ZNick Mathewsonnickm@torproject.org2025-02-03T18:41:15Zurn:sha1:7686f3a460ae511410f9e51f54e457635a972289rpclib: In tests, use an ersatz socketpair on windows.2025-02-03T17:00:20ZNick Mathewsonnickm@torproject.org2025-02-03T17:00:20Zurn:sha1:624b3b4bcb833954a34bdae4c8f1215ac9a44652
Fixes #1831.
I'm doing this because switching from the socketpair crate to an
ersatz connect-to-localhost socketpair made the test pass.
My windows skills are weak, but it appears possible that you aren't
supposed to simultaneously have a blocking ReadFile and a blocking
WriteFile to a named pipe from separate threads? At least, that's
consistent with our findings in !2758.
I first saw this hack in perl, when I needed it in 2003.
I am displeased that it is still apparently needed in 2025.
rpclib: make conn::complex use fewer iterations.2025-02-03T16:57:39ZNick Mathewsonnickm@torproject.org2025-02-03T16:57:39Zurn:sha1:150dbc30a6c9d85a51847ad77193040fae3e0506
This was the slowest test in our suite.
Merge branch 'rpc_document_internal_optimism' into 'main'2025-01-30T18:28:11ZNick Mathewsonnickm@torproject.org2025-01-30T18:28:11Zurn:sha1:f8d9cedfeecdb9bcdc7b006845c9856fed302f1f
rpc: Document what is actually going on with stream optimism.
Closes #1583
See merge request tpo/core/arti!2753rpc: Correct API documentation about optimism2025-01-30T15:08:17ZNick Mathewsonnickm@torproject.org2025-01-30T15:03:04Zurn:sha1:fcb10040764db7204b637713b4166c4f57235257
Our documentation had dated to an older version of our RPC stream
code, where all streams were automatically optimistic.
But as explained, our use of "optimistic"ness in RPC stream code is
now purely internal, to make it possible to get an DataStreamCtrl.
This isn't user-visible in our rpc_conn_open_stream code.
Closes #1583
fix: fix typos2025-01-30T08:39:30ZDimitris Apostoloudimitris.apostolou@icloud.com2025-01-30T08:39:30Zurn:sha1:6371829c976f6a5b77d46bf977f369a915f2ced3rpclib: Rename ConnPtSource to ConnPtOrigin.2025-01-29T14:17:21ZNick Mathewsonnickm@torproject.org2025-01-29T14:14:39Zurn:sha1:ebdd7c31d39fc043856a855dcea85d87ef6e0aa0