mirrors/arti.git/crates/arti-rpc-client-core/src/msgs, branch arti-v1.2.8mirror of https://gitlab.torproject.org/tpo/core/arti
http://git.dilluti0n.com/mirrors/arti.git/atom?h=arti-v1.2.82024-08-07T12:21:28Zrpclib: Rename ParsedRequest to ParsedRequestFields2024-08-07T12:21:28ZNick Mathewsonnickm@torproject.org2024-08-06T14:07:07Zurn:sha1:c05d234ced1e126ae975314484dd409c98f2f983
This name change should emphasize that the (module-private)
`ParsedRequestFields` type is only for parsing, and we aren't
supposed to actually construct them for our own requests.
With this change, and the others on the branch, there's no longer a
risk of trying to serialize a ParsedRequestFields (since it doesn't
implement Serialize), or to deserialize a Request (since it doesn't
implement Deserialize).
Closes #1511.
rpclib: Use JsonValue to re-encode requests.2024-08-07T12:21:28ZNick Mathewsonnickm@torproject.org2024-08-06T14:02:55Zurn:sha1:46c06e389ff71f819751001b916f509689acab4a
As with responses, we previously used a strategy that could have
failed in the future, if we forgot to add an "unexpected_fields"
member to one of our structs.
Closes #1512.
rpclib: Unify error type for ValidatedRequest failure.2024-08-07T12:21:28ZNick Mathewsonnickm@torproject.org2024-08-06T13:05:02Zurn:sha1:5756400a33f1a4e35d676aaa90bad69ac34aaab2rpclib: Refactor request canonicalization2024-08-07T12:21:28ZNick Mathewsonnickm@torproject.org2024-08-06T12:50:24Zurn:sha1:2eaa2dc0c902411b83365e9e2f11da268f98a8fd
This lets us make a couple of types module-private,
and prepares the way for using the serde_json::Value trick on
requests too.
rpclib: Ensure that re-encoded responses end with NL2024-08-07T12:21:28ZNick Mathewsonnickm@torproject.org2024-08-06T12:33:19Zurn:sha1:97efbdb6f305e6fa2158777a3f9171861a145961rpclib: Use JsonValue to re-encode responses2024-08-07T12:21:28ZNick Mathewsonnickm@torproject.org2024-08-06T12:06:27Zurn:sha1:8e3d728e08588e485146d8e14854622659d77ee3
This approach keeps the property that we still preserve any
unrecognized fields, but takes a different approach. Instead of
using our own `structs` to round-trip the json, we use a
`serde_json::Value`, to ensure that we cannot forget to add the
`unexpected_fields` element to a struct.
Merge branch 'rpc-reencoding' into 'main'2024-08-05T18:07:58ZNick Mathewsonnickm@torproject.org2024-08-05T18:07:58Zurn:sha1:32d95e1c99843f598afbfb85e30885d6bc2182fe
rpc-client-core: Always re-encode requests and responses, and preserve unrecognized struct fields.
Closes #1491
See merge request tpo/core/arti!2312rpclib: Apply serde(default) to RpcMeta::updates.2024-08-05T16:54:44ZNick Mathewsonnickm@torproject.org2024-08-05T16:54:44Zurn:sha1:2e5172690103cb9b60310fcdadfe441c01ca4a19
This enable a `meta` object to have no `updates` field set.
rpclib: re-encode responses from arti, and preserve fields.2024-08-04T18:14:48ZNick Mathewsonnickm@torproject.org2024-08-04T18:14:48Zurn:sha1:c611e138941342e3655bbb1ace50a963ab730bc9
We want to re-encode responses to avoid possible mismatch between
how arti-rpc-client-core parses messages and how the user application
parses messages. (In theory this shouldn't be necessary so long as
arti-rpc-client-core and arti have the same json implementation,
and arti-rpc-client-core is only used for talking to arti.
But those assumptions might change in the future.)
Closes #1491.
We want to preserve fields so that, if Arti adds any new elements
to response or error in the future, and the client knows about them,
they won't be lost simply because arti-rpc-client-core hasn't heard
of them.
rpclib: preserve unrecognized request fields2024-08-04T14:36:28ZNick Mathewsonnickm@torproject.org2024-08-04T14:36:28Zurn:sha1:ffba394c4e2df46f2a7130251b20b32df44f04e7
When writing a request, we want to keep any fields that we don't
recognize, in case the application (and arti) know about some
field that we haven't heard of.