mirrors/arti.git/crates/arti-rpc-client-core/src/msgs/request.rs, branch main mirror of https://gitlab.torproject.org/tpo/core/arti http://git.dilluti0n.com/mirrors/arti.git/atom?h=main 2026-06-09T15:36:01Z maint: Run maint/add_warning to deny string slices 2026-06-09T15:36:01Z Clara Engler cve@cve.cx 2026-06-09T15:36:01Z urn:sha1:9f5752a77fb57052c06ead0eeae606831f1e8e97 This commit executes maint/add_warning with the just added change to deny string slices except in tests. I recommend auditing this by checking out the previous commit followed by running the script yourself and then verifying that the diff is identical to this commit. This commit makes cargo clippy fail. We will add exceptions in the next commit. rpc: Clean up pub items in nb_stream. 2026-02-04T14:04:52Z Nick Mathewson nickm@torproject.org 2026-02-04T14:02:37Z urn:sha1:0a50351d0d3981d22f76507b88c314d95facd5a9 (We don't need as many of these to be public as I had originally thought.) Fix name of clippy lint to unchecked_time_subtraction (2) 2025-11-06T11:28:22Z Ian Jackson ijackson@chiark.greenend.org.uk 2025-11-06T11:23:25Z urn:sha1:a5fd5c48ea059a80cc1f6c50e248654b5ff3aaff Run maint/add_warning rpc-client: Increase test coverage for the msgs module 2025-03-18T16:08:23Z vcrn 3893-vcrn@gitlab.torproject.org 2025-03-18T16:08:23Z urn:sha1:e70fa298389e99183ff400726bf31e578c3d44c6 rpclib: Rename ParsedRequest to ParsedRequestFields 2024-08-07T12:21:28Z Nick Mathewson nickm@torproject.org 2024-08-06T14:07:07Z urn:sha1:c05d234ced1e126ae975314484dd409c98f2f983 This name change should emphasize that the (module-private) `ParsedRequestFields` type is only for parsing, and we aren't supposed to actually construct them for our own requests. With this change, and the others on the branch, there's no longer a risk of trying to serialize a ParsedRequestFields (since it doesn't implement Serialize), or to deserialize a Request (since it doesn't implement Deserialize). Closes #1511. rpclib: Use JsonValue to re-encode requests. 2024-08-07T12:21:28Z Nick Mathewson nickm@torproject.org 2024-08-06T14:02:55Z urn:sha1:46c06e389ff71f819751001b916f509689acab4a As with responses, we previously used a strategy that could have failed in the future, if we forgot to add an "unexpected_fields" member to one of our structs. Closes #1512. rpclib: Unify error type for ValidatedRequest failure. 2024-08-07T12:21:28Z Nick Mathewson nickm@torproject.org 2024-08-06T13:05:02Z urn:sha1:5756400a33f1a4e35d676aaa90bad69ac34aaab2 rpclib: Refactor request canonicalization 2024-08-07T12:21:28Z Nick Mathewson nickm@torproject.org 2024-08-06T12:50:24Z urn:sha1:2eaa2dc0c902411b83365e9e2f11da268f98a8fd This lets us make a couple of types module-private, and prepares the way for using the serde_json::Value trick on requests too. rpclib: Apply serde(default) to RpcMeta::updates. 2024-08-05T16:54:44Z Nick Mathewson nickm@torproject.org 2024-08-05T16:54:44Z urn:sha1:2e5172690103cb9b60310fcdadfe441c01ca4a19 This enable a `meta` object to have no `updates` field set. rpclib: preserve unrecognized request fields 2024-08-04T14:36:28Z Nick Mathewson nickm@torproject.org 2024-08-04T14:36:28Z urn:sha1:ffba394c4e2df46f2a7130251b20b32df44f04e7 When writing a request, we want to keep any fields that we don't recognize, in case the application (and arti) know about some field that we haven't heard of.