mirrors/arti.git/crates/arti-rpc-client-core/src/ffi, branch arti-v1.5.0

Fix warnings and errors from edition 2024.

2025-08-07T15:28:39Z

The two main causes of errors were: - Since some of the lifetime rules have changed, we no longer need to do as many "bind a variable and immediately return it" patterns, and so clippy now warns about them. - We needed to adjust the explicit captures (`use<...>`) in a couple of our RPIT instances.

Switch Cargo.toml files to edition 2024.

2025-08-07T15:28:36Z

First, run ``` git grep -l "^edition =" | xargs perl -i -pe 's/^edition *=.*/edition = "2024"/;' ``` Second, manually verify that all Cargo.toml files have changed, and nothing else has changed. Third, run cargo fmt again.

fix `clippy::doc_overindented_list_items`

2025-04-03T17:32:58Z

Example: ```text warning: doc list item overindented --> crates/arti-rpc-client-core/src/conn/connimpl.rs:322:9 | 322 | /// indicates that no more messages will be received for this request. | ^^^ help: try using ` ` (2 spaces) | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_overindented_list_items note: the lint level is defined here --> crates/arti-rpc-client-core/src/lib.rs:8:9 | 8 | #![warn(clippy::all)] | ^^^^^^^^^^^ = note: `#[warn(clippy::doc_overindented_list_items)]` implied by `#[warn(clippy::all)]` ```

AF_UNIX terminology: Rename two error variants

2025-03-24T13:58:54Z

Change `..UnixAddress...` to `...AfUnixAddress..`.

RPC: Abolish an unused and misnamed error variant

2025-03-24T13:58:54Z

This variant breaches the new guidelines about AF_UNIX terminology. And its purpose is unclear and it's not used.

rpclib: Improve output for ConnectFailure

2025-02-04T19:41:15Z

We want to explain better what has happened, not only with the final fatal error, but with any nonfatal errors that occurred in the middle. Closes #1826.

rpclib: Include sources when formatting FFI errors.

2025-02-04T19:41:15Z

Closes #1650.

rpclib: New combined error type for RPC connect failures.

2025-01-29T14:17:21Z

This type explains where every error came from, and explains why each declined connect point was declined.

arti-rpc-client-core: Rename Authentication{Rejected=>Failed}

2025-01-23T18:06:23Z

Also change corresponding message. This way, it will be clear that we're just reporting that Arti gave us an error—not that the error necessarily means that the authentication itself was "wrong".

rpclib: Avoid overuse of execute_internal_ok.

2025-01-23T18:06:23Z

The execute_internal_ok method converts every error response into an internal error; as such, it's only appropriate when there is no way for a well-behaved Arti instance to give an error response. But we had been using it in a few places where errors were possible under other circumstances. This commit fixes that behavior, and adds documentation to help avoid it.