mirrors/arti.git/crates/arti-rpc-client-core/src/ffi, branch arti-v1.4.6mirror of https://gitlab.torproject.org/tpo/core/arti
http://git.dilluti0n.com/mirrors/arti.git/atom?h=arti-v1.4.62025-04-03T17:32:58Zfix `clippy::doc_overindented_list_items`2025-04-03T17:32:58ZSteven Engleropara@torproject.org2025-04-03T17:21:49Zurn:sha1:663339ffa8bd00ce59c2dd39c288d338505263c3
Example:
```text
warning: doc list item overindented
--> crates/arti-rpc-client-core/src/conn/connimpl.rs:322:9
|
322 | /// indicates that no more messages will be received for this request.
| ^^^ help: try using ` ` (2 spaces)
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_overindented_list_items
note: the lint level is defined here
--> crates/arti-rpc-client-core/src/lib.rs:8:9
|
8 | #![warn(clippy::all)]
| ^^^^^^^^^^^
= note: `#[warn(clippy::doc_overindented_list_items)]` implied by `#[warn(clippy::all)]`
```
AF_UNIX terminology: Rename two error variants2025-03-24T13:58:54ZIan Jacksonijackson@chiark.greenend.org.uk2025-03-06T15:20:52Zurn:sha1:0f588e4bb3899521cd6d7ef4f4d10445e900f80a
Change `..UnixAddress...` to `...AfUnixAddress..`.
RPC: Abolish an unused and misnamed error variant2025-03-24T13:58:54ZIan Jacksonijackson@chiark.greenend.org.uk2025-03-06T15:41:32Zurn:sha1:4bc9e6c47dcd764b5d95a47b66fd27167458c8a8
This variant breaches the new guidelines about AF_UNIX terminology.
And its purpose is unclear and it's not used.
rpclib: Improve output for ConnectFailure2025-02-04T19:41:15ZNick Mathewsonnickm@torproject.org2025-02-04T17:28:02Zurn:sha1:dffe9330ab57d90f844f2aac950e4cbc2fc7a70b
We want to explain better what has happened, not only with the final
fatal error, but with any nonfatal errors that occurred in the middle.
Closes #1826.
rpclib: Include sources when formatting FFI errors.2025-02-04T19:41:15ZNick Mathewsonnickm@torproject.org2025-02-04T15:40:03Zurn:sha1:921ae4c6cea7893aae854e562720310388b8897b
Closes #1650.
rpclib: New combined error type for RPC connect failures.2025-01-29T14:17:21ZNick Mathewsonnickm@torproject.org2025-01-28T14:52:32Zurn:sha1:28cc171b91d315412286b52297e0973fd2431f41
This type explains where every error came from, and explains why
each declined connect point was declined.
arti-rpc-client-core: Rename Authentication{Rejected=>Failed}2025-01-23T18:06:23ZNick Mathewsonnickm@torproject.org2025-01-23T17:37:45Zurn:sha1:2d4872c41eec4d4ec27f022ede306b68d1583492
Also change corresponding message.
This way, it will be clear that we're just reporting that Arti
gave us an error—not that the error necessarily means that the
authentication itself was "wrong".
rpclib: Avoid overuse of execute_internal_ok.2025-01-23T18:06:23ZNick Mathewsonnickm@torproject.org2025-01-22T17:31:25Zurn:sha1:0d9ebbfacb4636597f661f89bfc5f24975aa7cb7
The execute_internal_ok method converts every error response into an
internal error; as such, it's only appropriate when there is no way
for a well-behaved Arti instance to give an error response.
But we had been using it in a few places where errors were possible
under other circumstances.
This commit fixes that behavior, and adds documentation to help
avoid it.
arti-rpc-client-core: Client side of cookie authentication.2025-01-15T14:18:44ZNick Mathewsonnickm@torproject.org2025-01-09T19:08:20Zurn:sha1:08e9de49b3a0f9d428b4e28e1eefceaba9fe74a8Implement banner for RPC protocol.2025-01-09T21:26:33ZNick Mathewsonnickm@torproject.org2025-01-08T15:06:26Zurn:sha1:fdf77750dcaa256c095daf6eb123129b8fd757b0
Closes #1753