mirrors/arti.git/crates/arti-rpc-client-core/src/ffi/util.rs, branch mainmirror of https://gitlab.torproject.org/tpo/core/arti
http://git.dilluti0n.com/mirrors/arti.git/atom?h=main2026-06-09T15:36:01Zmaint: Run maint/add_warning to deny string slices2026-06-09T15:36:01ZClara Englercve@cve.cx2026-06-09T15:36:01Zurn:sha1:9f5752a77fb57052c06ead0eeae606831f1e8e97
This commit executes maint/add_warning with the just added change to
deny string slices except in tests.
I recommend auditing this by checking out the previous commit followed
by running the script yourself and then verifying that the diff is
identical to this commit.
This commit makes cargo clippy fail. We will add exceptions in the next
commit.
rpclib: Rename `OutPtr` to `OutBoxedPtr`2025-11-06T22:00:39ZNeel Chauhanneel@neelc.org2025-11-05T02:13:24Zurn:sha1:e20e93ea05ddc7bb499bcb7cb0d99940e6b20c7e
Closes #1588.
Fix name of clippy lint to unchecked_time_subtraction (2)2025-11-06T11:28:22ZIan Jacksonijackson@chiark.greenend.org.uk2025-11-06T11:23:25Zurn:sha1:a5fd5c48ea059a80cc1f6c50e248654b5ff3aaff
Run maint/add_warning
Switch Cargo.toml files to edition 2024.2025-08-07T15:28:36ZNick Mathewsonnickm@torproject.org2025-08-06T01:19:58Zurn:sha1:77b0de43b8c67cdb81befe0680a3df43b6ad37bc
First, run
```
git grep -l "^edition =" |
xargs perl -i -pe 's/^edition *=.*/edition = "2024"/;'
```
Second, manually verify that all Cargo.toml files have changed,
and nothing else has changed.
Third, run cargo fmt again.
fix `clippy::doc_overindented_list_items`2025-04-03T17:32:58ZSteven Engleropara@torproject.org2025-04-03T17:21:49Zurn:sha1:663339ffa8bd00ce59c2dd39c288d338505263c3
Example:
```text
warning: doc list item overindented
--> crates/arti-rpc-client-core/src/conn/connimpl.rs:322:9
|
322 | /// indicates that no more messages will be received for this request.
| ^^^ help: try using ` ` (2 spaces)
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_overindented_list_items
note: the lint level is defined here
--> crates/arti-rpc-client-core/src/lib.rs:8:9
|
8 | #![warn(clippy::all)]
| ^^^^^^^^^^^
= note: `#[warn(clippy::doc_overindented_list_items)]` implied by `#[warn(clippy::all)]`
```
artilib: Take a different approach to sealing a pair of traits.2024-10-01T16:05:16ZNick Mathewsonnickm@torproject.org2024-09-30T21:44:28Zurn:sha1:3568b5db75a4ace28a034e8c176f51782a81b03f
This resolves a "TODO MSRV" comment.
rpclib: FFI for opening data streams.2024-09-09T14:52:56ZNick Mathewsonnickm@torproject.org2024-08-26T15:31:18Zurn:sha1:8fd335e5ae7ad761efe3030e33b7004ec70fc2ff
There's a blocking TODO here about exposing socks error codes that
I still need to solve.
Fix typos2024-09-03T08:09:02ZDimitris Apostoloudimitris.apostolou@icloud.com2024-09-03T08:09:02Zurn:sha1:676f913463b7d84f34dd6101b99d03ef79cf57adrpclib: Remove in_mut_ptr_opt, and document why.2024-08-27T13:45:12ZNick Mathewsonnickm@torproject.org2024-08-27T13:31:39Zurn:sha1:c4095ec63f2967f9704e5c1d8eb3eb8f57803ecbrpclib, ffi: Allow simultaneous calls to `arti_rpc_handle_wait()`2024-08-27T13:45:12ZNick Mathewsonnickm@torproject.org2024-08-22T15:21:48Zurn:sha1:76e6a24759b5fc1a04b53077acb19afb82c8df88
Its underlying function previously took `&mut RpcHandle`,
which was an accident waiting to happen. Now it takes `&RpcHandle`
and includes a Mutex to prevent multiple threads from waiting for
updates on the same request ID at once.
As an alternative, we *could* try to update connimpl::Receiver to
allow multiple simultaneous listeners on the same request ID.
But that would (I think) require a lot more bookkeeping, and thus
would be a bit more error-prone.
Closes #1532.