mirrors/arti.git/crates/arti-rpc-client-core/src/conn, branch arti-v1.2.8mirror of https://gitlab.torproject.org/tpo/core/arti
http://git.dilluti0n.com/mirrors/arti.git/atom?h=arti-v1.2.82024-09-25T15:52:58Zrpclib: read SOCKS _after_ processing.2024-09-25T15:52:58ZNick Mathewsonnickm@torproject.org2024-09-24T20:37:37Zurn:sha1:8da8b88481c26d49ac96e79165538e01237ec9ed
When doing the client handshake, we need to read data _after_ we
check for stuff to send, since the client speaks first in the socks
protocol.
Without this patch, the socks handshake just stalls.
Merge branch 'socks_read_zero' into 'main'2024-09-25T15:52:17ZNick Mathewsonnickm@torproject.org2024-09-25T15:52:17Zurn:sha1:654c5b211ad54c073c1d1661b1448f931e985487
socks users: detect closed sockets. (TROVE-2024-011)
Closes #1635
See merge request tpo/core/arti!2447Merge branch 'rename_singleton_id' into 'main'2024-09-25T15:25:52ZJim Newsomejnewsome@torproject.org2024-09-25T15:25:52Zurn:sha1:8753eb8294ff4eedf4f4d6ba26e918a7eb1635aa
rpc: Rename SingletonId to SingleIdResponse
Closes #1585
See merge request tpo/core/arti!2448socks users: detect closed sockets.2024-09-24T20:35:07ZNick Mathewsonnickm@torproject.org2024-09-24T18:16:42Zurn:sha1:0c595818f713916d94b7b0e4062f953fad7c9799
Without this check, our socks code can enter an infinite loop
if a socket is closed at the wrong time.
Resolves TROVE-2024-011.
Fixes #1635.
rpc: Rename SingletonId to SingleIdResponse2024-09-24T14:23:53ZNick Mathewsonnickm@torproject.org2024-09-24T14:21:17Zurn:sha1:bd9b29b05de6c133b93366acb69d9e2ce6b126cd
Calling it "singleton" might have suggested that it was using the
[singleton pattern](https://en.wikipedia.org/wiki/Singleton_pattern),
which it isn't.
(Renaming done with rust-analyzer and double-checked with `git grep`.)
Closes #1585.
rpclib: Use prop351 protocol to open streams.2024-09-19T00:30:00ZNick Mathewsonnickm@torproject.org2024-09-18T23:35:42Zurn:sha1:56b60b5b84222c78bae75f28fb5d185eac71b319
Now that prop351 is what Arti speaks, it's what the rpclib
needs to provide.
Note one change in particular: the `isolation` string
is no longer an optional argument when opening a stream.
(With prop351, there is no longer such a thing as an "absent"
isolation string, and we don't want to imply that there is a
difference between None and "".)
rpclib: Remove TODO about connect=>stream renaming.2024-09-10T19:46:29ZNick Mathewsonnickm@torproject.org2024-09-10T19:46:29Zurn:sha1:d9e1c9acea23ed45e030c549260dc65e6eb339c1
AFIACT, all of this renaming is done. I've grepped for `[Cc]onn`
and didn't find any more identifiers that needed to be renamed.
rpclib: Rename "connect" to "open_stream" as appropriate.2024-09-10T19:41:33ZNick Mathewsonnickm@torproject.org2024-09-10T19:41:33Zurn:sha1:7ed0e1216439f3b7ad7a662f47b3a6f947627e13rpclib: Rename connect.rs to stream.rs2024-09-10T18:25:43ZNick Mathewsonnickm@torproject.org2024-09-10T18:25:43Zurn:sha1:10728f57bcbb1b42cc3efec5ac07b507d916c1a2
(This is about DataStreams, so we should make it less confusing.
This commit is _just_ about the file renaming, with no associated
function renaming.)
Add TODO for renaming connect.rs to streams.rs2024-09-09T14:52:56ZNick Mathewsonnickm@torproject.org2024-09-04T17:52:34Zurn:sha1:b90160a8efd8999d5f0820be1358c89a10ca9fd1