mirrors/arti.git/crates/arti-rpc-client-core/src/conn/auth.rs, branch mainmirror of https://gitlab.torproject.org/tpo/core/arti
http://git.dilluti0n.com/mirrors/arti.git/atom?h=main2025-12-01T10:38:17Zrpc-client-core: Add missing CookieBeginReply docs2025-12-01T10:38:17ZGabriela Moldovangabi@torproject.org2025-12-01T10:38:03Zurn:sha1:e59048d8b015e998e2c96f150b203436a7769ab4Switch Cargo.toml files to edition 2024.2025-08-07T15:28:36ZNick Mathewsonnickm@torproject.org2025-08-06T01:19:58Zurn:sha1:77b0de43b8c67cdb81befe0680a3df43b6ad37bc
First, run
```
git grep -l "^edition =" |
xargs perl -i -pe 's/^edition *=.*/edition = "2024"/;'
```
Second, manually verify that all Cargo.toml files have changed,
and nothing else has changed.
Third, run cargo fmt again.
squash! Upgrade rand dependency to 0.9.2025-03-18T16:09:44ZNick Mathewsonnickm@torproject.org2025-03-18T13:01:31Zurn:sha1:2f8993c22c2b86010e4fd8b5169ef0ab83f8c754
- `rand::thread_rng()` has been deprecated and renamed to `rand::rng()`
arti-rpc-client-core: Rename Authentication{Rejected=>Failed}2025-01-23T18:06:23ZNick Mathewsonnickm@torproject.org2025-01-23T17:37:45Zurn:sha1:2d4872c41eec4d4ec27f022ede306b68d1583492
Also change corresponding message.
This way, it will be clear that we're just reporting that Arti
gave us an error—not that the error necessarily means that the
authentication itself was "wrong".
rpclib: Avoid overuse of execute_internal_ok.2025-01-23T18:06:23ZNick Mathewsonnickm@torproject.org2025-01-22T17:31:25Zurn:sha1:0d9ebbfacb4636597f661f89bfc5f24975aa7cb7
The execute_internal_ok method converts every error response into an
internal error; as such, it's only appropriate when there is no way
for a well-behaved Arti instance to give an error response.
But we had been using it in a few places where errors were possible
under other circumstances.
This commit fixes that behavior, and adds documentation to help
avoid it.
rpclib: Rename params/reply structs for consistency.2025-01-21T17:33:28ZNick Mathewsonnickm@torproject.org2025-01-21T17:07:06Zurn:sha1:5261146a20385d575f815533c2b92f4f34035799
Our now convention here in rpclib is that a struct holding a
request's parameters is called `FooParams`, and a struct holding
that request's reply is called `FooReply`.
Closes #1586
rpclib: Add a note about where cookie auth is documented.2025-01-15T20:11:15ZNick Mathewsonnickm@torproject.org2025-01-15T20:11:15Zurn:sha1:43d379f3a4a288e9f7dcb5df43cfe206d30fc5f8rpclib: Clean up after performing cookie auth2025-01-15T19:58:11ZNick Mathewsonnickm@torproject.org2025-01-15T19:56:49Zurn:sha1:794da10e7c485a9e962f7496d1a0b7344b92fb39
Previously we never released the intermediary cookie-auth object,
which would have left it kicking around on the RPC server side
until we finally closed our connection.
rpc: Tweak cookie protocol to bind both nonces.2025-01-15T14:18:44ZNick Mathewsonnickm@torproject.org2025-01-09T19:55:50Zurn:sha1:f3fcd71f218595402175c2530a09dabb7ed10f9d
Previously participants in the cookie protocol only bound the peer
nonce in their MACs. With this change, they bind both nonces.
This change is _probably_ not necessary for security, but it can't
hurt. It follows a general principle that Adam Langley told me a
long time ago: you won't regret binding more, but you might regret
binding less.
arti-rpc-client-core: Client side of cookie authentication.2025-01-15T14:18:44ZNick Mathewsonnickm@torproject.org2025-01-09T19:08:20Zurn:sha1:08e9de49b3a0f9d428b4e28e1eefceaba9fe74a8