mirror of https://gitlab.torproject.org/tpo/core/arti http://git.dilluti0n.com/mirrors/arti.git/atom?h=arti-v1.2.6 2024-07-31T17:57:03Z 2024-07-31T17:57:03Z Nick Mathewson nickm@torproject.org 2024-07-31T17:57:03Z urn:sha1:4497317f07df7a0f13bddc4e7a7727dbe12532b9 2024-07-31T17:54:16Z Nick Mathewson nickm@torproject.org 2024-07-25T13:52:56Z urn:sha1:6b1f266a8405d7c07b10e5cf2b153c575e6f2288 Per discussion, we'd rather have an optional output parameter for error objects rather than mess with thread-local variables. This is possibly less convenient for direct usage from C, but likely more convenient for wrapper functions in other languages. 2024-07-31T17:54:16Z Nick Mathewson nickm@torproject.org 2024-07-24T19:13:40Z urn:sha1:5265d6c1aa3c14ef09d908c9695eb1f003253d33 In this API, borrowed strings are `const char *`, and owned strings are `ArtiRpcStr *`. You can get the former from the latter with `arti_rpc_str_get()`, which returns a `const char *` in hopes that you will neither modify nor free() that `const char *` (Note that there are no places where string ownership needs to be passed into this library; and at present, there is only one case where it is passed out. I do not anticipate that we will need to do intake of owned strings. We will probably need to return these in a few more cases as we add more API surface.) 2024-07-31T17:54:16Z Nick Mathewson nickm@torproject.org 2024-07-17T18:49:55Z urn:sha1:7e48f725dd665c5ff6eb07f16bd4957274767f6c 2024-07-31T17:54:16Z Nick Mathewson nickm@torproject.org 2024-07-17T15:16:44Z urn:sha1:544487c333fd5199d36fe4ddf781c70bfd9ee020 This is a bit complicated since: - Using cbindgen with macro expansion requires a nightly rust: so, we have to look for one. - There are some cbindgen warnings which I cannot find any way to suppress, so instead of giving all warnings, it seems better to give a diff from the old list of warnings to the new list.