mirrors/arti.git/crates/arti-relay/src/tasks/crypto, branch arti-v2.5.0

maint: Run maint/add_warning to deny string slices

2026-06-09T15:36:01Z

This commit executes maint/add_warning with the just added change to deny string slices except in tests. I recommend auditing this by checking out the previous commit followed by running the script yourself and then verifying that the diff is identical to this commit. This commit makes cargo clippy fail. We will add exceptions in the next commit.

relay: Recompute valid_until cache in view constructor

2026-05-28T16:11:56Z

The recompute of the valid_until cache is done now in the constructor of FullKeyView so the view is directly usable once built. Else, the caller always need to call the recompute function which is error prone especially when used as a throwaway view. Also, without this change, building the view and then attempting to log the public keys would fail. Signed-off-by: David Goulet

relay: Introduce src/task/crypto/keys.rs

2026-05-28T16:11:56Z

Move all key related action function to keys.rs in order to alleviate crypto.rs. The Reactor will get more functionnalities soon so cleanup. No behavior change, just code movement. Related to #2548

relay: Make FullKeyView pub(super)

2026-05-28T16:11:56Z

Now, the FullKeyView is officially only seen by the crypto task. Signed-off-by: David Goulet

relay: Remove locking of FullKeyView

2026-05-28T16:11:56Z

No need for the valid_until cache locking that used to ensure coherent view accross tasks. As we move towards having the FullKeyView be solely owned by the crypto task, no need for locking. Future commit will introduce a control command channel which will be used to get keys for other tasks. The valid_until cache is kept though because it helps with key lookups to avoid walking all keys each time. Signed-off-by: David Goulet

relay: Avoid using super::super:: and instead import

2026-05-26T17:29:05Z

Signed-off-by: David Goulet

relay: Use a struct for key valid_until cache

2026-05-26T17:29:05Z

Instead of a HashMap, use a struct that contains explicit valid_until value per key type as those won't change anytime soon. This is to have a smaller memory footprint and simpler design. Signed-off-by: David Goulet

relay: Rename crypto task reconcile() to recompute_valid_until()

2026-05-26T17:29:05Z

Signed-off-by: David Goulet

relay: .expect() on mutex lock failure

2026-05-26T17:29:05Z

This change made it that we don't need Result<> to be returned for two functions therefore affecting the callsites. Signed-off-by: David Goulet

relay: Add unit test for key view reconcile()

2026-05-26T17:29:05Z

Signed-off-by: David Goulet