mirror of https://gitlab.torproject.org/tpo/core/arti http://git.dilluti0n.com/mirrors/arti.git/atom?h=arti-v0.4.0 2022-05-27T13:01:20Z 2022-05-27T13:01:20Z Nick Mathewson nickm@torproject.org 2022-05-27T13:01:20Z urn:sha1:b232365a75249d6f767127feb2a47286f9ece762 I followed the following procedure to make these changes: * I used maint/changed_crates to find out which crates had changed since 0.3.0. * I used grep and maint/list_crates to sort those crates in topological (dependency) order. * I looked through semver_status to find which crates were listed as having semver-relevant changes (new APIs and breaking changes). * I scanned through the git logs of the crates with no semver-relevant changes listed to confirm that, indeed, they had no changes. For those crates, I incremented their patch-level version _without_ changing the version that other crates depend on. * I scanned through the git logs of the crates with no semver-relevant changes listed to confirm that, indeed, they had no obvious breaking changes. * I treated all crates that depend on `arti` and/or `arti-client` as having breaking changes. * I identified crates that depend on crates that have changed, even if they have not changed themselves, and identified them as having a non-breaking change. * For all of the crates, I used `cargo set-version -p $CRATE --bump $STATUS` (where `STATUS` is `patch` or `minor`) to update the versions, and the depended-upon versions. 2022-05-25T20:25:58Z trinity-1686a trinity@deuxfleurs.fr 2022-05-25T15:37:19Z urn:sha1:b380c25e6637b2cf48239eea8c4a3707eb3aa67e 2022-05-13T11:42:30Z Ian Jackson ijackson@chiark.greenend.org.uk 2022-05-13T10:42:51Z urn:sha1:4e2bd6c7983dfa1adab59180e034c68bbe167daf 2022-05-13T11:42:30Z Ian Jackson ijackson@chiark.greenend.org.uk 2022-05-13T10:31:02Z urn:sha1:44d2f5ccfd6e94e705c4abc29a2e69db38dfdf19 This crate no longer has any reason to exist. All its remaining functionality is generic enough to go into tor-config. In this commit, we move the contents of lib.rs into a new file in tor-config. It contains: * Code motion * The minimal "mod" and "use" changes * The minimal doc comment * A new a compat alias for ConfigurationSources. The compat alias is there because various crates currently speak of arti_config::ConfigurationSources and it is most convenient to fix them up after the type is available in tor_config. 2022-05-13T11:41:27Z Ian Jackson ijackson@chiark.greenend.org.uk 2022-05-13T10:18:28Z urn:sha1:cdde87846cd74843e7dce7bc02652564f04cd467 That's where this definitions is now. This test ought to have been moved in Move default_config_file() into arti-client 2022-05-13T09:58:29Z Ian Jackson ijackson@chiark.greenend.org.uk 2022-05-13T09:55:56Z urn:sha1:bdb7cb7a6d1a146dfd4466c2463f35d5e20bcd03 2022-05-13T09:58:29Z Ian Jackson ijackson@chiark.greenend.org.uk 2022-05-12T14:12:33Z urn:sha1:d7f84b92abab46df146b98b74055b175d3b72f50 As per https://gitlab.torproject.org/tpo/core/arti/-/issues/472 Experimentation convinced me the Mistrust should be within the ConfigurationSources. 2022-05-12T13:55:39Z Ian Jackson ijackson@chiark.greenend.org.uk 2022-05-11T16:46:23Z urn:sha1:c9c8344b735a213c5a65ee12cd099bdd7bf1e631 2022-05-12T13:55:03Z Ian Jackson ijackson@chiark.greenend.org.uk 2022-05-11T15:29:33Z urn:sha1:afa64bf3978f3d7a8c33f868f62b5ddaea50c236 This is redundant, because the defaults have to be supplied by the config builders (usually via builder default attributes). That this is actually done and correct is tested by the `default_config()` test case in arti/src/cfg.rs. 2022-05-11T17:23:05Z Ian Jackson ijackson@chiark.greenend.org.uk 2022-05-11T10:22:22Z urn:sha1:ab3bd9d6d589cb23048603528913b375acfa8dd9 This does not know anything about arti, only about TOML and Config. Code motion, plus necessary import adjustments.