mirrors/arti.git/crates/arti-config/src, branch arti-v0.4.0 mirror of https://gitlab.torproject.org/tpo/core/arti http://git.dilluti0n.com/mirrors/arti.git/atom?h=arti-v0.4.0 2022-05-13T11:42:30Z Abolish arti-config, replacing with tombstone crate 2022-05-13T11:42:30Z Ian Jackson ijackson@chiark.greenend.org.uk 2022-05-13T10:42:51Z urn:sha1:4e2bd6c7983dfa1adab59180e034c68bbe167daf arti-config abolition: Move functionality to tor-config 2022-05-13T11:42:30Z Ian Jackson ijackson@chiark.greenend.org.uk 2022-05-13T10:31:02Z urn:sha1:44d2f5ccfd6e94e705c4abc29a2e69db38dfdf19 This crate no longer has any reason to exist. All its remaining functionality is generic enough to go into tor-config. In this commit, we move the contents of lib.rs into a new file in tor-config. It contains: * Code motion * The minimal "mod" and "use" changes * The minimal doc comment * A new a compat alias for ConfigurationSources. The compat alias is there because various crates currently speak of arti_config::ConfigurationSources and it is most convenient to fix them up after the type is available in tor_config. arti-config: Move default config file test to arti-client 2022-05-13T11:41:27Z Ian Jackson ijackson@chiark.greenend.org.uk 2022-05-13T10:18:28Z urn:sha1:cdde87846cd74843e7dce7bc02652564f04cd467 That's where this definitions is now. This test ought to have been moved in Move default_config_file() into arti-client Fix comment location 2022-05-13T09:58:29Z Ian Jackson ijackson@chiark.greenend.org.uk 2022-05-13T09:55:56Z urn:sha1:bdb7cb7a6d1a146dfd4466c2463f35d5e20bcd03 config load: Move mistrust checking to load() 2022-05-13T09:58:29Z Ian Jackson ijackson@chiark.greenend.org.uk 2022-05-12T14:12:33Z urn:sha1:d7f84b92abab46df146b98b74055b175d3b72f50 As per https://gitlab.torproject.org/tpo/core/arti/-/issues/472 Experimentation convinced me the Mistrust should be within the ConfigurationSources. ARTI_DEFAULTS: Move to arti crate 2022-05-12T13:55:39Z Ian Jackson ijackson@chiark.greenend.org.uk 2022-05-11T16:46:23Z urn:sha1:c9c8344b735a213c5a65ee12cd099bdd7bf1e631 config defaults: No longer apply ARTI_DEFAULTS in load() 2022-05-12T13:55:03Z Ian Jackson ijackson@chiark.greenend.org.uk 2022-05-11T15:29:33Z urn:sha1:afa64bf3978f3d7a8c33f868f62b5ddaea50c236 This is redundant, because the defaults have to be supplied by the config builders (usually via builder default attributes). That this is actually done and correct is tested by the `default_config()` test case in arti/src/cfg.rs. arti-config: Move cmdline to tor-config 2022-05-11T17:23:05Z Ian Jackson ijackson@chiark.greenend.org.uk 2022-05-11T10:22:22Z urn:sha1:ab3bd9d6d589cb23048603528913b375acfa8dd9 This does not know anything about arti, only about TOML and Config. Code motion, plus necessary import adjustments. Move default_config_file() into arti-client 2022-05-11T14:53:03Z Ian Jackson ijackson@chiark.greenend.org.uk 2022-05-11T11:46:42Z urn:sha1:8fe62da87118fc21994866386eef164404d31a92 This will let other embedders use it. ConfigurationSources: Have the generics take Into<owned> 2022-05-11T14:53:03Z Ian Jackson ijackson@chiark.greenend.org.uk 2022-05-11T11:47:35Z urn:sha1:c76c79d0235451e915d22cbaa874fa273034bdcd These generic arguments weren't consistent. It doesn't make sense ot insist on getting a borrowed type and then cloning it. So tidy things up in the direction of taking owned values, which is what ConfigurationSources actually needs. (My personal preference would be &dyn to avoid monomorphisation code bloat but that was controversial last time I proposed it somewhere.)