mirrors/arti.git/crates/arti-config/src/options.rs, branch arti-v0.0.2mirror of https://gitlab.torproject.org/tpo/core/arti
http://git.dilluti0n.com/mirrors/arti.git/atom?h=arti-v0.0.22021-11-29T19:20:34ZChange sane_defaults() and with_directories()2021-11-29T19:20:34ZNick Mathewsonnickm@torproject.org2021-11-29T19:20:34Zurn:sha1:f107794b742fb075c673249999362afd28d77772
The sane_defaults() call is now the same as you get from a default
builder: by convention, we just call that method Default::default().
The with_directories() constructor makes more sense as a constructor
for the TorClientConfigBuilder than for TorClientConfig.
Document StorageConfig defaults better.2021-11-29T18:55:33ZNick Mathewsonnickm@torproject.org2021-11-29T18:55:33Zurn:sha1:098547f735bd993da9445693d5b1664c031a9f20
(Also fix a couple of typos)
Add basic tests for high-level builders2021-11-25T14:40:16ZNick Mathewsonnickm@torproject.org2021-11-24T16:47:44Zurn:sha1:f2034ac6e2d1340c9d4c4a2ea47ffa5272dac934
Make sure that we can change elements, and we can reconstruct builders
that give us the same thing.
Implement builder patterns for ArtiConfig.2021-11-25T14:40:14ZNick Mathewsonnickm@torproject.org2021-11-24T15:41:50Zurn:sha1:3a91f363bbf8309926f4e8b5488afa3ada68be8a
This commit implements the "metabuilder" pattern and the "builder
reconstruction" pattern for the ArtiConfig type.
I'm not 100% that this will be necessary, but it will certainly help
with testing.
Impl and test Default for high-level configs2021-11-25T14:39:11ZNick Mathewsonnickm@torproject.org2021-11-24T15:11:35Zurn:sha1:75d977a25937c6b70e0841962d45cc78783c08ecImplement meta-builder pattern for TorClientConfig2021-11-22T14:53:52ZNick Mathewsonnickm@torproject.org2021-11-22T00:05:47Zurn:sha1:307ca9b4d052c60e8e496012005efe1df6b90724
This should be ergonomic than having to construct every section of the
configuration separately.
Make every Config type implement Eq.2021-11-21T17:06:15ZNick Mathewsonnickm@torproject.org2021-11-21T17:06:15Zurn:sha1:40ff7113d41c9d5ec3435ae410399d59f26e81f2
Doing this is necessary for reconfiguration support, and will help a lot
with testing, too.
For every* config type, make defaults consistent.2021-11-21T16:52:43ZNick Mathewsonnickm@torproject.org2021-11-21T16:52:43Zurn:sha1:e7fdf05f50aea214c2ac4dabcb309910e9d59fd0
This patch makes sure that for every* config type we have, the defaults
you get from a Builder match those you get from Serde, and that both
match the value that you get from arti_defaults.toml. Later down the
line I'll be adding some tests to keep these in sync.
* StorageConfig still has no defaults of its own, since we aren't so
sure we want other applications to use Arti's directories by default.
Give every ConfigBuilder a From<Config> implementation.2021-11-21T15:54:34ZNick Mathewsonnickm@torproject.org2021-11-21T02:23:00Zurn:sha1:97f5a7a357d94ad2f0837a499b68dbf6f79a4040
This will make it more convenient to reconfigure things.
Ensure that every section-level config type has a builder() function.2021-11-21T15:54:34ZNick Mathewsonnickm@torproject.org2021-11-21T02:00:20Zurn:sha1:aa83a5e38aba302efb2bd6b3eaf634ba9413d5d8