mirrors/arti.git/crates/arti-client/src, branch arti-v1.2.4mirror of https://gitlab.torproject.org/tpo/core/arti
http://git.dilluti0n.com/mirrors/arti.git/atom?h=arti-v1.2.42024-06-03T14:28:23Zarti-client: Unconditionally retire all HS circuits if circmgr says so.2024-06-03T14:28:23ZGabi Moldovangabi@gotpcrel.net2024-06-03T13:01:46Zurn:sha1:0c96190b5035713ee301e6ef43fe4cf1040f608d
If the circmgr retires all of its circuits, so should the HS circ pool.
The circuits can be retired for various reasons (for example, if the
configured vanguard mode changes).
arti-client: Add TODO about always clearing the HS circ pool.2024-06-03T14:28:23ZGabriela Moldovangabi@torproject.org2024-05-23T16:49:40Zurn:sha1:936e23fd3fd3986c7c1d2bdeb5c9e45a0baa58f9tor-circmgr: Remove VanguardMode from Pool (fmt).2024-06-03T14:28:22ZGabriela Moldovangabi@torproject.org2024-05-23T16:40:51Zurn:sha1:2deb0b5df8c7d7e14ab151781b3f3b30180aa210tor-circmgr: Remove VanguardMode from Pool.2024-06-03T14:19:24ZGabriela Moldovangabi@torproject.org2024-05-23T16:38:33Zurn:sha1:d75f136e506e474274529e4d0fee742d5b5d9011
Storing the VanguardMode in multiple places (in the VanguardMgr *and*
the HS circ Pool) is dangerous and can lead to split brain situations
where different parts of the code think they are running in different
VanguardModes.
See #1424
tor-guardmgr: Unconditionally define VanguardConfig.2024-06-03T09:47:32ZGabriela Moldovangabi@torproject.org2024-05-13T13:13:30Zurn:sha1:d17dc599c09af08ef501dfba3a685081491bb17a
We want to export the `VanguardConfig` even if the `vanguards` feature
is disabled (we will need to unconditionally include it in the arti
config).
Note that if `vanguards` are disabled, the `VanguardMode` from the
`VanguardConfig` can only be `Dsiabled`.
arti-client: Remove unnecessary VanguardConfig pub use.2024-06-03T09:47:32ZGabriela Moldovangabi@torproject.org2024-05-13T15:07:28Zurn:sha1:1f91d5e5ace8b31504fe86c4e49d7818cc91ebe3
This is already exported via the `pub mod vanguards` module, so there is
no need to export it from the top-level too. This *is* a breaking change,
but the downstream fix is trivial (and the type should never have been
exported directly from `arti_client::config` in the first place).
RPC: Require an Error type in methods.2024-05-16T12:40:06ZNick Mathewsonnickm@torproject.org2024-05-14T18:19:30Zurn:sha1:98765e5a4cdf70356db38d324b0896d2b6f83c2f
This is needed so that we can cast special methods' return types
properly.
I wish I could make this optional, but Rust doesn't allow
defaulting an associated type.
RPC: Use RPC method names in a consistent format.2024-05-14T13:33:36ZNick Mathewsonnickm@torproject.org2024-05-14T13:33:36Zurn:sha1:24efb91741ba1acc139207ee805d385240f8c393
Specifically, we want a single colon, and we want our
method names to be in snake_case.
RPC: Add notes about ClientConnectionTarget2024-05-14T12:04:03ZNick Mathewsonnickm@torproject.org2024-05-13T15:34:48Zurn:sha1:74b6d08d7ecdf2536289392fb2a79e890f4f95b3
Document its relation to the method system, and possible future
evolution.
RPC: Require DynClone for ClientConnectionError.2024-05-14T12:04:03ZNick Mathewsonnickm@torproject.org2024-05-13T15:19:21Zurn:sha1:cb9ae08a5fe9e035b5d72562d05e33d16ca821d0