mirror of https://gitlab.torproject.org/tpo/core/arti http://git.dilluti0n.com/mirrors/arti.git/atom?h=arti-v1.1.6 2023-06-12T17:35:28Z 2023-06-12T17:35:28Z Nick Mathewson nickm@torproject.org 2023-06-07T17:30:36Z urn:sha1:8166a29746b8fa7b447fc0f3929668e35c3314ae This is a rather tricky piece of functionality. It works as follows. We introduce a `CastTable` type. Each `CastTable` tells us how to downcast `dyn Object` for objects of a single concrete type. The `Object` type now has a `get_casttable` method that returns an empty `CastTable` by default. `CastTable` is, internally, a map from the `TypeId` of the target dyn Trait reference type to a function `fn(&dyn Object) -> &dyn Trait`. These functions are stored as `Box<dyn Any + ...>`. (They are Boxed because they may refer to generic functions, which you can't get a static reference to, and they're Any because the functions have different types.) The `decl_object!` macro now implements `get_casttable` as appropriate. (The syntax is a bit janky, but that's what we get for not using derive_adhoc.) For non-generic types, `get_casttable` uses a Lazy<CastTable>`. to initialize a CastTable exactly once. For generic types, it use a `Lazy<RwLock<HashMap<..>>` to build one CastTable per instantiation of the generic type. This could probably be optimized a bit more, the yaks could be shaved in a more scintillating hairstyle, and the syntax for generic `decl_object` could definitely be improved. 2023-06-07T18:37:04Z Nick Mathewson nickm@torproject.org 2023-06-07T18:36:46Z urn:sha1:999f914e030e77d9439f0cb6910af10def33d518 2023-05-04T14:35:03Z Nick Mathewson nickm@torproject.org 2023-04-20T18:17:16Z urn:sha1:d7ab388faf96f53e7981e8307f51a16e7891627b Because of #837, we won't be able to work with _every_ TorClient<R>, so I'm only going to be using TorClient<PreferredRuntime> for now.