mirror of https://gitlab.torproject.org/tpo/core/arti http://git.dilluti0n.com/mirrors/arti.git/atom?h=arti-v1.2.0 2024-02-22T18:00:34Z 2024-02-22T18:00:34Z Gabriela Moldovan gabi@torproject.org 2024-02-21T18:55:20Z urn:sha1:d6c554d36833a61b71c9af68d9299e92ed820ff2 2024-02-22T18:00:34Z Gabriela Moldovan gabi@torproject.org 2024-02-21T18:53:59Z urn:sha1:79fa5573a26eed11ee90a93a01fdb504f0fc56d2 Closes #1283 2024-02-21T14:58:46Z Gabriela Moldovan gabi@torproject.org 2024-02-21T12:46:20Z urn:sha1:90addac031b7242b9352ce2c635b9802e657fabe Closes #1202 2024-02-12T11:38:36Z Ian Jackson ijackson@chiark.greenend.org.uk 2024-02-12T11:08:20Z urn:sha1:7eafea9d0b7bb5b1ccc2980df1c94defdd04a954 Reviewing uses of `#[educe(default)]`, I came across these two places where it was applied to a non-generic struct without any special attributes on fields. std's derive will do just as well here. 2024-02-12T11:38:36Z Ian Jackson ijackson@chiark.greenend.org.uk 2024-02-12T11:07:42Z urn:sha1:c35c60f848154e80f23ba95a989ff2f9d2594e6a Since Rust 1.66, std's default works properly for enums, provided that the default variant is a unit. Review all uses of `#[educe(default)]` on enums and replace them with std where possible, which is most of them. In 1.66 and later, std's `#[derive(Default)]` doesn't infer any generic bounds on the derived impl, where it's an enum - since the unit variant can always be constructed. So this change doesn't add any generic bounds and is not API-visible. 2024-02-01T11:21:44Z Ian Jackson ijackson@chiark.greenend.org.uk 2024-01-31T14:13:25Z urn:sha1:b1d40b7d8c562cfee352cdf7852c065938acf702 2024-02-01T11:21:44Z Ian Jackson ijackson@chiark.greenend.org.uk 2024-01-30T16:12:33Z urn:sha1:4ccf20f165cb39e8f3da0a56eab55ea4fe1e4dd1 2024-02-01T11:21:44Z Ian Jackson ijackson@chiark.greenend.org.uk 2024-01-30T15:42:13Z urn:sha1:b4a7f0fca0d231eb9c0298b78deee9ed3c1bbc7e We no longer do replay log locking in IptManager::new. Instead, we rely on the acquire_instance call in OnionService::launch, which ends up with ipt_mgr getting an InstanceHandle (which contains a lock guard). OnionServiceStateMgr is abolished; it existed to deal with the generics in the tor_persist::StateMgr API. state_dir has no generics (other than the T being loaded/stored). Many places (structs and argument lists) now have state_dir types which embody a path (or a CheckeDir) along with a lock, rather than separate path+lock+mistrust. The creation/startup code uses the new calls from state_dir. Other more minor changes: - StartupError::StateDirectoryInaccessible contains tor_persist::Error - test::create_storage_handles_from_state_dir changed and renamed, from _from_state_mgr. - replay::PersistFile's (separate) file lock is now fslock_guard's 2024-01-31T10:43:06Z Gabriela Moldovan gabi@torproject.org 2024-01-30T19:14:09Z urn:sha1:a60aaaa9851733bc93139e800d4b49276df024d6 2024-01-31T10:43:06Z Gabriela Moldovan gabi@torproject.org 2024-01-30T19:12:14Z urn:sha1:86ee7ebc1be82ef7b6f4672c0b1677efbfb8b074 Service nicknames are represented by `HsNickname`, so let's rename `HsClientSpecifier` to `HsClientNickname`.