mirrors/arti.git/crates/arti-client/src/client.rs, branch arti-v1.1.4 mirror of https://gitlab.torproject.org/tpo/core/arti http://git.dilluti0n.com/mirrors/arti.git/atom?h=arti-v1.1.4 2023-03-30T16:20:54Z Merge branch 'plumb' into 'main' 2023-03-30T16:20:54Z Alexander Færøy ahf@torproject.org 2023-03-30T16:20:54Z urn:sha1:bcb051fea49e0323bfe4f7d4bc8e99b64efa16f2 More plumbing for hs connections See merge request tpo/core/arti!1098 Run rustfmt 2023-03-30T14:58:47Z Ian Jackson ijackson@chiark.greenend.org.uk 2023-03-30T14:56:29Z urn:sha1:23c7bd9174c454c5eb9ba83c8d580384434c1baa Apply this churn, which I deferred for ease of review. arti-client: Call HsCircPool::launch_background_tasks 2023-03-30T14:58:09Z Ian Jackson ijackson@chiark.greenend.org.uk 2023-03-30T13:54:15Z urn:sha1:a14d18d295579b5a42f8198e466a41b5d4242e00 I found that I had the bug where I forgot to call this function, and reached bad_api_usage!("The circuit launcher wasn't initialized") The possibility of such a bug is a hazard of this API pattern. arti-client: When making hs conn, wait for bootstrap 2023-03-30T14:49:07Z Ian Jackson ijackson@chiark.greenend.org.uk 2023-03-30T14:27:26Z urn:sha1:255b9cac9643f12707e078e0c2ba28110d3c40fe Not doing this was a bug. The bug was possible because of some code duplication between the exit and hs paths. Add a comment about that. tor-client: Pass a netdir for each request 2023-03-30T14:49:07Z Ian Jackson ijackson@chiark.greenend.org.uk 2023-03-28T16:32:37Z urn:sha1:926abf3ade85776e73e32b9d803febc5b1326453 This will be more convenient inside tor-hsclient. In arti-client, this mirrors the way TorClient::get_or_launch_exit_circ works. Move functionality from tor_basic_utils to tor_async_utils 2023-03-29T17:57:11Z Nick Mathewson nickm@torproject.org 2023-03-29T13:17:13Z urn:sha1:a62affd66e34e98035bd14cb67b355065598a2d7 This commit is mostly code movement; I'd recommend reviewing it with git's `--color-moved` option. Pass HsCircPool to hsclient connect function, not CircMgr (fmt) 2023-03-28T14:49:45Z Ian Jackson ijackson@chiark.greenend.org.uk 2023-03-28T14:45:11Z urn:sha1:df8e4dd49774a4fc365d1ac56ec1d6affa227cf4 Pass HsCircPool to hsclient connect function, not CircMgr 2023-03-28T14:49:45Z Ian Jackson ijackson@chiark.greenend.org.uk 2023-03-28T11:18:06Z urn:sha1:9b6be7eaa77f16be33cdebc75e6a68ee67a913b1 We separated this out in the circmgr API. This is what the HS client needs. It doesn't want to participate in the general circuit pool. Apply deferred rustfmt churn 2023-03-23T11:50:18Z Ian Jackson ijackson@chiark.greenend.org.uk 2023-03-23T11:25:57Z urn:sha1:b6f5c066b4bca59aa24ac7827d5ca4255d375fcd arti-client: Include redacted HsId in ObtainHsCircuit error 2023-03-23T11:50:18Z Ian Jackson ijackson@chiark.greenend.org.uk 2023-03-23T11:24:59Z urn:sha1:9d7983a6ea3969fafad184ec6030ee853151e72b As per https://gitlab.torproject.org/tpo/core/arti/-/merge_requests/1071/diffs?commit_id=580fe1118dbbbfa086d11b28e3e26d7c91afe21c#fbd7ab2d6d0a5b515697d4f9f99a42ebd508aa4b_153_165