mirrors/arti.git/clippy.toml, branch arti-v2.5.1mirror of https://gitlab.torproject.org/tpo/core/arti
http://git.dilluti0n.com/mirrors/arti.git/atom?h=arti-v2.5.12026-07-23T10:13:34Zclippy config: Forbid TimeRangeBound::if_valid_now2026-07-23T10:13:34ZIan Jacksonijackson@chiark.greenend.org.uk2026-07-20T16:55:48Zurn:sha1:9931210ab6943371401435a7a4bdcb091805caa5clippy: Add an xref re random_range to the comment2026-05-13T13:10:52ZIan Jacksonijackson@chiark.greenend.org.uk2026-05-13T13:10:04Zurn:sha1:6c96094166f0a33ba03fdd1743b84d6242e25502
As per
https://gitlab.torproject.org/tpo/core/arti/-/merge_requests/3982#note_3410614
clippy: disallow random_range standalone method too2026-05-13T13:10:52ZIan Jacksonijackson@chiark.greenend.org.uk2026-05-13T11:36:38Zurn:sha1:064b0a92c0666f9e37de18e4b819fad6b36b922f
Upstream rand have provided a convenient alias for causing your
program to panic. How helpful.
clippy: Work around bug where it claims method doesn't exist2026-05-13T13:10:52ZIan Jacksonijackson@chiark.greenend.org.uk2026-05-13T11:17:32Zurn:sha1:1578e0644e5da7f4db0169250c2eac9f2291e7d8
Fixes
warning: `rand::RngExt::random_range` does not refer to a reachable function
--> /volatile/rustcargo/Rustup/Arti/arti/clippy.toml:7:5
|
7 | { path = "rand::RngExt::random_range", reason = "Prefer tor_basic_utils::RngExt::gen_range_checked to avoid uncontrolled panics, or gen_range_infallible if applicable" },
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: add `allow-invalid = true` to the entry to suppress this warning
Upgrade rand crates to 0.10.2026-05-12T20:55:43ZWesley Aptekar-Casselsme@wesleyac.com2026-05-07T20:06:21Zurn:sha1:a18167928901d8c88cd1cdd87346de8ad1ee42a2
When the circ-padding feature is enabled, we use maybenot, which does
not yet support rand 0.10. In the meantime, enabling this feature pulls
in rand 0.9. This is not ideal, but should be okay as a temporary
situation.
This also replaces the use of ReseedingRng (which was removed in 0.10)
with the reseeding_rng crate. This is somewhat less performant, but it
should be okay.
clippy.toml: Forbid the various "now" methods.2026-03-26T19:20:17ZNick Mathewsonnickm@torproject.org2026-03-26T16:10:07Zurn:sha1:7b0ac40f948aeb73afa81c4f868531640da01f62
By doing this, we make sure that everybody is using the correct
types and methods.
maint: warn if `retain` method is used from 'weak_table' crate2026-01-12T19:21:28ZSteven Engleropara@torproject.org2026-01-12T19:17:57Zurn:sha1:2f68289ada062ad1da80cc028cbf8393d516ccb9
The retain method is broken on these types. I only tested
`WeakValueHashMap` and `WeakHashSet`, but it's likely that the other
types are broken as well.
We don't use this method currently, but it would be easy to accidentally
use it in the future. Let's try to catch this bug early, and if it
happens to get fixed, then it's easy to remove this lint.
refactor: convert Extend to inherent method, forbid push/extend, fix rend_handshake time2025-12-17T14:48:03ZNihal4218-nihalxkumar@gitlab.torproject.org2025-12-11T15:33:26Zurn:sha1:5ad66c991c71f21e307fd5f78d09b099685a5520refactor: remove early returns and forbid push() via clippy2025-12-17T14:48:03ZNihal4218-nihalxkumar@gitlab.torproject.org2025-12-10T13:28:30Zurn:sha1:294d34ec95338966e56063150050ddd4d85fa1bamaint: add clippy warning for `futures::task::SpawnExt`2025-11-05T02:59:43ZSteven Engleropara@torproject.org2025-11-05T02:59:43Zurn:sha1:55d236af4485cbee7a0bdc8f9a1d52e05d7b3760